Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[NETBEANS-1074] Module Review libs.commons_fileupload #786

Merged
merged 1 commit into from
Aug 27, 2018
Merged

[NETBEANS-1074] Module Review libs.commons_fileupload #786

merged 1 commit into from
Aug 27, 2018

Conversation

arusinha-zz
Copy link

No description provided.

matthiasblaesing
matthiasblaesing requested changes Aug 24, 2018
View reviewed changes
Copy link
Contributor

@matthiasblaesing matthiasblaesing left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add a -notice file. the library is deeloped by an ASF project, so it carries a mandatory notice file, that file needs to be included here.

See o.apache.commons.io for an example.

@arusinha-zz arusinha-zz force-pushed the module-review-libs.commons_fileupload branch from 7a32d1c to fdcc553 Compare August 27, 2018 05:38
@arusinha-zz
Copy link
Author

Added the notice file

@matthiasblaesing
Copy link
Contributor

Thank you.

@matthiasblaesing matthiasblaesing merged commit 6b36e58 into apache:master Aug 27, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthiasblaesing matthiasblaesing matthiasblaesing approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@arusinha-zz @matthiasblaesing