[NETBEANS-1342] Hide the panel for iOS in the Mobile Platforms Options #953
Conversation
Just hide the panel because the cordova.platforms.ios module is not available (see apache#856)
|
But when we hide it, we need to hide the cordova option inside of the HTML5/JS project too and to hide the cordova project template too. |
|
I'm not sure about cordova but I think we should remove cordova modules from the cluster if we will not support cordova yet. |
There was a problem hiding this comment.
There are also some IOS-related factories in CordovaBrowserFactory shouldn't they move to ios support module ? CordovaPanel source defines controls related to IOS, but I can't find a place where the panel is added to a visible parent - is it a dead code ?
Re. remove: I've removed the ios module from the cluster because of license issues, but there's also android support, which seemed to be license-OK.
webcommon/cordova/src/org/netbeans/modules/cordova/CordovaPerformer.java
Show resolved
Hide resolved
Just check whether PlatformManager.getPlatform(PlatformManager.IOS_TYPE) is null
junichi11
force-pushed
the
netbeans-1342
branch
from
288fb01
to
d428744
Compare
Maybe, we should do so. I'm not an expert this area. So if you can do that, I'll leave it to you as another problem :) I just wanted to fix NETBEANS-1342 (NPE).
Yes, I know it. I thought so. But I thought need not to add the cordova modules if we need to hide cordova options and project templates (Chris wrote above). |
I'm not sure what this means, sorry... CordovaPanel is MobilePlatformsPanel? |
There was a problem hiding this comment.
Great. Ideally, we'd also find time to figure out why the Cordova support, specifically that panel, does not work in Apache NetBeans 10 vs. 8.2 where it worked. But the question can also be asked how many were using this feature in the first place, I guess by excluding this functionality, we'll soon find out. :-) Ah, I see: #856
|
Excluding is, in my opinion not an option as long as we don't have a good working NBAndroid Plugin, where it can live there. Hiding for the first thing is good, the rest shouldn't that hard to figure it out. I would prefer adding more feature instead of removing, otherwise, the users will find/use another IDE. IMHO. But of course this should be discussed at the mailing list. |
|
@sdedic I'm not sure about that because I'm not the author, but I could also not find it... Just in case, I'll hide the iOSPanel. |
|
If there is no problem, let's squash and merge. At least, this change prevents NPE, I think. |
|
Cool, go ahead. |
apache#953) * [NETBEANS-1342] Hide the panel for iOS in the Mobile Platforms Options Just hide the panel because the cordova.platforms.ios module is not available (see apache#856) * Prevent NPE Just check whether PlatformManager.getPlatform(PlatformManager.IOS_TYPE) is null * Hide iOSPanel in the CordovaPanel
apache#953) * [NETBEANS-1342] Hide the panel for iOS in the Mobile Platforms Options Just hide the panel because the cordova.platforms.ios module is not available (see apache#856) * Prevent NPE Just check whether PlatformManager.getPlatform(PlatformManager.IOS_TYPE) is null * Hide iOSPanel in the CordovaPanel
https://issues.apache.org/jira/browse/NETBEANS-1342
Just hide the panel because the cordova.platforms.ios module is not available (see #856)