Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NLPCRAFT-72: POM fixes (make Stanford dependencies optional). #3

Merged
merged 1 commit into from Jun 6, 2020
Merged

NLPCRAFT-72: POM fixes (make Stanford dependencies optional). #3

merged 1 commit into from Jun 6, 2020

Conversation

syermakov
Copy link
Member

Summary of changes:

  • Moved all the source code from the root src folder to the nlpcraft module
  • Added new nlpcraft-stanford module to store Stanford CoreNLP-related sources
  • Added new stanford-corenlp Maven profile to include/exclude nlpcraft-stanford module from builds
  • Modified bin/prepare.sh script to reflected all of the above changes

@aradzinski
Copy link
Contributor

Looks good to me. mvn clear package verify works.

@skhdl
Copy link
Contributor

skhdl commented Jun 5, 2020

Looks good to me.

@syermakov syermakov merged commit ac77a3b into master Jun 6, 2020
@syermakov syermakov deleted the NLPCRAFT-72 branch June 6, 2020 10:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aradzinski aradzinski Awaiting requested review from aradzinski

@skhdl skhdl Awaiting requested review from skhdl

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
3 participants
@syermakov @aradzinski @skhdl