Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bluetooth Networking fixes #2153

Merged
merged 5 commits into from
Oct 29, 2020
Merged

Bluetooth Networking fixes #2153

merged 5 commits into from
Oct 29, 2020

Conversation

protobits
Copy link
Contributor

@protobits protobits commented Oct 29, 2020 •
edited by btashton
Loading

Summary

Fix various small issues in bt net layer:

  • bt_netdev.c: wrong placement of DEBUGASSERT (checks pointer before being set)
  • bt_hci: add various definitions, better expose some fields
  • bt_hcicore.c: fix handling of advertising report; use correct advertising interval
  • bt_conn.c: use definition names instead of hardcoded numbers

Impact

Fixes some bugs

Testing

Bluetooth normal work

btashton
btashton approved these changes Oct 29, 2020
View reviewed changes
Copy link
Contributor

@btashton btashton left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I edited the summary to include the commit headers so it is easier quickly look at the PR and see what was done.

@btashton btashton merged commit 5c2750a into apache:master Oct 29, 2020
@btashton btashton mentioned this pull request Oct 30, 2020
Merged
@ldube ldube mentioned this pull request Apr 23, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@btashton btashton btashton approved these changes

Assignees
No one assigned
Labels
backport/10.0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@protobits @btashton