Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

net/local: Add an option to specify the prefix of named pipe #2811

Merged
merged 1 commit into from Feb 5, 2021

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

to avoid the user create socket under the real filesystem
which isn't supported by nuttx VFS yet.

Impact

path like this "/tmp/test" don't fail anymore.

Testing

to avoid the user create socket under the real filesystem
which isn't supported by nuttx VFS yet.

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
Change-Id: Ib04c90e9c3c5a215bfda65515498d81e5f834895
Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should the default be "" so this is not a breaking change?

@xiaoxiang781216
Copy link
Contributor Author

Should the default be "" so this is not a breaking change?

How to generate the pipe name is implementation detail(the path is already different from the user provided because the code appends the suffix(CS/SC/HD) to the path), the caller should never access the pipe by open/close pipe directly. And since all local socket api change to use the new path, the prefix addition is transparent to the caller.

@davids5
Copy link
Contributor

davids5 commented Feb 5, 2021

Should the default be "" so this is not a breaking change?

How to generate the pipe name is implementation detail(the path is already different from the user provided because the code appends the suffix(CS/SC/HD) to the path), the caller should never access the pipe by open/close pipe directly. And since all local socket api change to use the new path, the prefix addition is transparent to the caller.

@xiaoxiang781216 - Thank you for the clarification.

@davids5 davids5 merged commit 1a9267d into apache:master Feb 5, 2021
@xiaoxiang781216 xiaoxiang781216 deleted the local branch February 5, 2021 13:32
@btashton btashton added this to To-Add in Release Notes - 10.1.0 Apr 12, 2021
@jerpelea jerpelea moved this from To-Add to Minor in Release Notes - 10.1.0 Apr 12, 2021
@jerpelea jerpelea moved this from Minor to Added in Release Notes - 10.1.0 Apr 16, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

2 participants