Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

add dma support for PolarFire SoC #3920

Merged
merged 1 commit into from
Jun 16, 2021
Merged

Conversation

jrosberg
Copy link
Contributor

Summary

Initial basic DMA support.
This version don't have any fancy channel allocation support etc. To be done later.
note: PDMA on MPFS is memory-to-memory only.

Impact

None - new code

Testing

Tested with Icicles board.

@jrosberg
Copy link
Contributor Author

what's the best way to handle styling of this long line: (nxstyle don't like it)

EXTERN uint64_t mpfs_dma_get_current_destination(enum mpfs_dma_channel_e channel);

rename function?
or split the line (from where?)

@patacongo
Copy link
Contributor

what's the best way to handle styling of this long line: (nxstyle don't like it)

EXTERN uint64_t mpfs_dma_get_current_destination(enum mpfs_dma_channel_e channel);

rename function?
or split the line (from where?)

First, I would try to remove the EXTERN. That is not normally present and not necessary unless called from C++ (which is shouldn't be) and it is not also enclosed int EXTERN "C" {}

It is also fairly common to divide a line between the return type and the function name like:

EXTERN uint64_t
mpfs_dma_get_current_destination(enum mpfs_dma_channel_e channel);

curr and dest and also very standard shortenings of current and destination.

@jrosberg
Copy link
Contributor Author

Removed that channel enum. I like it more this way.

@xiaoxiang781216 xiaoxiang781216 merged commit 673f951 into apache:master Jun 16, 2021
@jrosberg jrosberg deleted the mpfs_dma branch June 17, 2021 08:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants