net/tcp: add window scale support #4070
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
anchao
force-pushed
the
21070502
branch
2 times, most recently
from
e88deff
to
229e67e
Compare
yamt
requested changes
Jul 5, 2021
|
I upload a new commit. When the window scale is enabled, the received buffer is easily over 64K. I modified the related data type to uint32_t to avoid the TCP window overflow. Please review again. Thank you. |
anchao
force-pushed
the
21070502
branch
2 times, most recently
from
2877a46
to
f5d8ae3
Compare
yamt
reviewed
Jul 6, 2021
anchao
force-pushed
the
21070502
branch
2 times, most recently
from
d8707f4
to
29f54e1
Compare
Signed-off-by: chao.an <anchao@xiaomi.com>
Signed-off-by: chao.an <anchao@xiaomi.com>
yamt
approved these changes
Jul 6, 2021
Reference here: https://tools.ietf.org/html/rfc1323 Signed-off-by: chao.an <anchao@xiaomi.com>
1. change all window relative value type to uint32_t 2. move window range validity check(UINT16_MAX) before assembling TCP header Signed-off-by: chao.an <anchao@xiaomi.com>
xiaoxiang781216
approved these changes
Jul 7, 2021
|
LGTM, @yamt please take a look. |
yamt
approved these changes
Jul 7, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
net/tcp: add window scale support
net/tcp: change the tcp optdata to dynamic arrays
net/tcp: remove the invalid break during tcp option loop
Reference here:
https://tools.ietf.org/html/rfc1323
Impact
High performance network throughput request if the receiving window exceeds 64K
Testing
HTTP streaming