STM32 DAC Driver - Add support to DAC3 #4255
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acassis
reviewed
Aug 1, 2021
|
|
||
| /* Register the DAC driver at "/dev/dac0" */ | ||
|
|
||
| ret = dac_register("/dev/dac0", g_dac5); |
There was a problem hiding this comment.
What will happen if CONFIG_STM32_DAC1CH1 and CONFIG_STM32_DAC3CH2 be defined? I think it will fail to register the second "/dev/dac0". I think you need to avoid it.
There was a problem hiding this comment.
You are right. I will change the register path of DAC3CH2 to "/dev/dac5".
Thanks
raiden00pl
reviewed
Aug 2, 2021
COMP example was changed to use DAC3CH2 signal on COMP INM input.
daniel-p-carvalho
force-pushed
the
stm32-dac
branch
from
6a3ae78
to
d7cee36
Compare
|
There is any update about this PR? Thanks |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add support to DAC3 for STM32G4 devices. The nucleo-g431kb:comp configuration was changed to use DAC3CH2 signal on
COMP2 inverting input. The voltage on inverting input can be changed using dac tool.
Impact
Testing
Tested on nucleo-g431kb board.