-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Xtensa/RISC-V] Remove FAR and CODE qualifiers from arch-specific files #4590
Conversation
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Please, ignore the nxstyle errors due to mixed case on the ESP32-C3 BLE adapter.
|
8f011ac
to
10144c2
Compare
@gustavonihei do you plan to apply the same change to other arch(e.g. arm, sim...)? |
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
10144c2
to
4e1f755
Compare
I think it is important to consider those other archs, but not on this PR. |
I thank we can ignore the style warning in these patches. |
what's the motivation of the change? make the code look neater? a downside of this kind of changes is that it can introduce unnecessary differences among implementations which were otherwise more similar. |
Exactly. This will make the code cleaner, which benefits readability.
Soon other archs may also have FAR and CODE removed, so this won’t be an issue. |
Summary
This PR intends to remove all references to the
FAR
andCODE
qualifiers from Xtensa and RISC-V files.FAR
andCODE
are defined to nothing on both architectures.Impact
Should have no impact.
Testing
CI build pass.