Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Xtensa/RISC-V] Remove FAR and CODE qualifiers from arch-specific files #4590

Merged
merged 6 commits into from
Sep 22, 2021

Conversation

gustavonihei
Copy link
Contributor

@gustavonihei gustavonihei commented Sep 21, 2021

Summary

This PR intends to remove all references to the FAR and CODE qualifiers from Xtensa and RISC-V files.
FAR and CODE are defined to nothing on both architectures.

Impact

Should have no impact.

Testing

CI build pass.

Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
@gustavonihei
Copy link
Contributor Author

Please, ignore the nxstyle errors due to mixed case on the ESP32-C3 BLE adapter.

Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/esp32c3/esp32c3_ble_adapter.c:333:12: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/esp32c3/esp32c3_ble_adapter.c:334:12: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/esp32c3/esp32c3_ble_adapter.c:335:11: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/esp32c3/esp32c3_ble_adapter.c:2407:9: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/esp32c3/esp32c3_ble_adapter.c:2431:2: error: Mixed case identifier found
Error: /home/runner/work/incubator-nuttx/incubator-nuttx/nuttx/arch/risc-v/src/esp32c3/esp32c3_ble_adapter.c:2455:8: error: Mixed case identifier found
Error: Process completed with exit code 1.

@xiaoxiang781216
Copy link
Contributor

@gustavonihei do you plan to apply the same change to other arch(e.g. arm, sim...)?

Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
Signed-off-by: Gustavo Henrique Nihei <gustavo.nihei@espressif.com>
@gustavonihei
Copy link
Contributor Author

@gustavonihei do you plan to apply the same change to other arch(e.g. arm, sim...)?

I think it is important to consider those other archs, but not on this PR.
The changes begin with a simple find/sed, but then the manual changes for nxstyle take a considerable amount of time.

@xiaoxiang781216
Copy link
Contributor

I thank we can ignore the style warning in these patches.

@yamt
Copy link
Contributor

yamt commented Sep 22, 2021

what's the motivation of the change? make the code look neater?

a downside of this kind of changes is that it can introduce unnecessary differences among implementations which were otherwise more similar.

@gustavonihei
Copy link
Contributor Author

what's the motivation of the change? make the code look neater?

Exactly. This will make the code cleaner, which benefits readability.

a downside of this kind of changes is that it can introduce unnecessary differences among implementations which were otherwise more similar.

Soon other archs may also have FAR and CODE removed, so this won’t be an issue.

@saramonteiro saramonteiro merged commit e651ef0 into apache:master Sep 22, 2021
@gustavonihei gustavonihei deleted the hotfix/remove_far branch September 22, 2021 11:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants