Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

procfs: Remove mallinfo from struct procfs_meminfo_entry_s #5764

Merged
merged 1 commit into from
Mar 17, 2022

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

let's call mm_mallinfo directly

Impact

Code refactor

Testing

Pass CI

let's call mm_mallinfo directly

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@acassis
Copy link
Contributor

acassis commented Mar 17, 2022

Hi @xiaoxiang781216 what are the benefit of this modification? I think the code became simple/easier, but are other benefits doing this way?

@xiaoxiang781216
Copy link
Contributor Author

Hi @xiaoxiang781216 what are the benefit of this modification? I think the code became simple/easier, but are other benefits doing this way?

@acassis for consistence. You can see that meminfo_read already call mm_memdump directly, which make the abstraction through callback look very strange.

@acassis acassis merged commit c2a1d0f into apache:master Mar 17, 2022
@xiaoxiang781216 xiaoxiang781216 deleted the mallinfo branch March 17, 2022 17:59
@jerpelea jerpelea added this to To-Add in Release Notes - 11.0.0 Aug 30, 2022
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 11.0.0 Sep 1, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

3 participants