fix: pthread_rwlock_timedwrlock. #5931
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jihandong
force-pushed
the
topic-20220401-1
branch
from
67a1152
to
a29bc3c
Compare
jihandong
force-pushed
the
topic-20220401-1
branch
from
a29bc3c
to
7bc93c7
Compare
pkarashchenko
requested changes
Apr 6, 2022
jihandong
force-pushed
the
topic-20220401-1
branch
from
7bc93c7
to
dcfe499
Compare
jihandong
force-pushed
the
topic-20220401-1
branch
from
dcfe499
to
8f3eca0
Compare
jihandong
force-pushed
the
topic-20220401-1
branch
2 times, most recently
from
2ad8cae
to
8b7e104
Compare
jihandong
force-pushed
the
topic-20220401-1
branch
from
8b7e104
to
dcb8605
Compare
pthread_condclockwait() can not distinguish between interrupt and timeout, which cause these API not follow POSIX: pthread_rwlock_timedrdlock() pthread_rwlock_timedwrlock() pthread_condtimedwait() POSIX: Upon return from the signal handler the thread resumes waiting for the condition variable as if it wasnot interrupted These functions shall not return an error code of [EINTR]. Replacing nxsem_wait() with nxsem_clockwait_uninterruptible() can solve it. Signed-off-by: jihandong <jihandong@xiaomi.com>
jihandong
force-pushed
the
topic-20220401-1
branch
from
dcb8605
to
22d307d
Compare
|
@pkarashchenko could you review again? The change look good for me now. |
|
Will review later today |
xiaoxiang781216
approved these changes
May 19, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Upon return from the signal handler the thread shall resume waiting
as if it is not interrupted.
Add error return ETIMEOUT to nxsem_wait().
Signed-off-by: jihandong jihandong@xiaomi.com