arch, boards: cxd56xx: Minor update for spresense #6036
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Update loader and gnssfw to version 2.2.20585
Add necessary include header named debug.h for using ferr and finfo.
Add critical section to scu one-shot sequencer.
It caused i2c tool not to work due to i2c uninitializing processing. Since this process is not necessary in the normal case, we will move it to the error case.
Add a weak_function to the board_late_initialize function so that it can be replaced by another file, such as a user application.
Add Kconfig choice for selecting RST and DC pins on ILI934x LCD.
Add board function for SCD41 CO2, temperature and humidity sensor driver.
Add a mechanism to callback to an application to notice the SDCard status is changed (inserted or ejected).
|
|
||
| case BOARDIOC_SDCARD_SETNOTIFYCB: | ||
| { | ||
| ret = board_sdcard_set_state_cb(arg); |
There was a problem hiding this comment.
I think passing function pointers from app to kernel is not the best thing. Why such functionality is needed?
There was a problem hiding this comment.
Same question, could we use automount instead?
There was a problem hiding this comment.
Please consider enabling FS_AUTOMOUNTER_DRIVER and using a ioctl(FIOC_NOTIFY) instead of direct callback
There was a problem hiding this comment.
If not, then the anyway we need to rework this to be a signal based notification instead of direct callback
There was a problem hiding this comment.
I think that such improvements should be done in another PR.
xiaoxiang781216
approved these changes
Apr 11, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Impact
Only for spresense board.
Testing
Build and test on spresense board.