-
Notifications
You must be signed in to change notification settings - Fork 1.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
arch, boards: cxd56xx: Minor update for spresense #6036
Conversation
Update loader and gnssfw to version 2.2.20585
Add necessary include header named debug.h for using ferr and finfo.
Add critical section to scu one-shot sequencer.
It caused i2c tool not to work due to i2c uninitializing processing. Since this process is not necessary in the normal case, we will move it to the error case.
Add a weak_function to the board_late_initialize function so that it can be replaced by another file, such as a user application.
Add Kconfig choice for selecting RST and DC pins on ILI934x LCD.
Add board function for SCD41 CO2, temperature and humidity sensor driver.
Add a mechanism to callback to an application to notice the SDCard status is changed (inserted or ejected).
|
||
case BOARDIOC_SDCARD_SETNOTIFYCB: | ||
{ | ||
ret = board_sdcard_set_state_cb(arg); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think passing function pointers from app to kernel is not the best thing. Why such functionality is needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same question, could we use automount instead?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please consider enabling FS_AUTOMOUNTER_DRIVER
and using a ioctl(FIOC_NOTIFY)
instead of direct callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If not, then the anyway we need to rework this to be a signal based notification instead of direct callback
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think that such improvements should be done in another PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Summary
Impact
Only for spresense board.
Testing
Build and test on spresense board.