Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libc/stdio: Enable LIBC_FLOATINGPOINT by default if ARCH_FPU is enabled #6607

Merged
merged 1 commit into from
Jul 21, 2022
Merged

libc/stdio: Enable LIBC_FLOATINGPOINT by default if ARCH_FPU is enabled #6607

merged 1 commit into from
Jul 21, 2022

Conversation

xiaoxiang781216
Copy link
Contributor

Summary

and DEFAULT_SMALL is false

Impact

avoid the wrong configuration for the newbie

Testing

Pass CI

pkarashchenko
pkarashchenko approved these changes Jul 13, 2022
View reviewed changes
Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@pkarashchenko
Copy link
Contributor

Looks like at least boards/arm/stm32f7/nucleo-144/configs/f746-pysim/defconfig should be modified as well.

@xiaoxiang781216
libc/stdio: Enable LIBC_FLOATINGPOINT by default if ARCH_FPU is enabled
39e5134 
and DEFAULT_SMALL is false

Signed-off-by: Xiang Xiao <xiaoxiang@xiaomi.com>
@xiaoxiang781216
Copy link
Contributor Author

Looks like at least boards/arm/stm32f7/nucleo-144/configs/f746-pysim/defconfig should be modified as well.

Done.

@pkarashchenko pkarashchenko self-requested a review July 14, 2022 13:58
@pkarashchenko
Copy link
Contributor

boards/risc-v/mpfs/m100pfsevp/configs/nsh/defconfig needs to be updated

@xiaoxiang781216 xiaoxiang781216 mentioned this pull request Jul 19, 2022
Merged
@pkarashchenko
Copy link
Contributor

@hartmannathan could you please review?

@hartmannathan
Copy link
Contributor

hartmannathan commented Jul 20, 2022 •
edited

@hartmannathan could you please review?

@pkarashchenko Sure, I'll review soon. Thanks

hartmannathan
hartmannathan approved these changes Jul 21, 2022
View reviewed changes
Copy link
Contributor

@hartmannathan hartmannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM thanks!

@hartmannathan hartmannathan merged commit 1d43b4a into apache:master Jul 21, 2022
@xiaoxiang781216 xiaoxiang781216 deleted the printf2 branch July 21, 2022 15:56
@jerpelea jerpelea added this to To-Add in Release Notes - 11.0.0 Aug 30, 2022
@jerpelea jerpelea moved this from To-Add to Added in Release Notes - 11.0.0 Sep 2, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pkarashchenko pkarashchenko pkarashchenko approved these changes

@hartmannathan hartmannathan hartmannathan approved these changes

@acassis acassis Awaiting requested review from acassis

Assignees
No one assigned
Labels
None yet
Projects
No open projects
Release Notes - 11.0.0
Added
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@xiaoxiang781216 @pkarashchenko @hartmannathan