Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

FS disable FS_LARGEFILE by default #6773

Merged
merged 3 commits into from Aug 4, 2022

Conversation

PetervdPerk-NXP
Copy link
Contributor

Summary

#4193 Introduced LFS support.
However it seems that it's enabled by default as well.
Whereas many applications don't have a need for LFS support i.e. FAT32 is 4GB limited and solutions such as NXFFS, LittleFS and SmartFS run on smaller flash chips.

Therefore I propose to disable this feature by default because it has a big impact on 32bit systems regarding program size and runtime memory size.

If people want to have to large file support on a microcontroller I think it makes sense they have to manually enable this feature.

Impact

CONFIG_FS_LARGEFILE Enabled

   text    data     bss     dec     hex filename
 162996     792   23856  187644   2dcfc nuttx

CONFIG_FS_LARGEFILE Disabled

   text    data     bss     dec     hex filename
 160268     792   23856  184916   2d254 nuttx

Testing

Copy link
Contributor

@davids5 davids5 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

SMALL is a relative term (and will change over time). So when too many things are roll up into it, it makes for really poor granularity on feature control.

Copy link
Contributor

@pkarashchenko pkarashchenko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some defconfig files still should be updated

@pkarashchenko
Copy link
Contributor

Seems that SPIFS also need to select an option

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Development

Successfully merging this pull request may close these issues.

None yet

5 participants