Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

s32k1xx: Allow building with debug features and no console. #7217

Merged
merged 1 commit into from
Sep 30, 2022

Conversation

csanchezdll
Copy link
Contributor

Summary

If no LPUART console is selected, but DEBUG_FEATURES is enabled, building fails for s32k1xx boards.

Impact

This prevents using custom consoles different from LPUART based ones.

Testing

  1. tools/configure.sh s32k148evb:nsh
  2. make menuconfig
  • Device Drivers -> Serial Driver Support -> Serial console: select "No serial console"
  • Build Setup -> Debug Options -> Enable Debug Features: check
  1. make
    Build fails:
                 from chip/s32k1xx_lowputc.c:36:
chip/s32k1xx_lowputc.c: In function 's32k1xx_lowputc':
chip/s32k1xx_lowputc.c:391:20: error: 'S32K1XX_CONSOLE_BASE' undeclared (first use in this function); did you mean 'S32K1XX_GPIOE_BASE'?
  391 |   while ((getreg32(S32K1XX_CONSOLE_BASE + S32K1XX_LPUART_STAT_OFFSET) &
      |                    ^~~~~~~~~~~~~~~~~~~~```

After applying the PR, build succeeds with the same procedure.



Copy link
Contributor

@hartmannathan hartmannathan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@pkarashchenko pkarashchenko merged commit 68db81a into apache:master Sep 30, 2022
@csanchezdll csanchezdll deleted the s32k1xx_no_console_debug branch November 2, 2022 07:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants