Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(service/webdav): Add docker-compose file to simplify the CI #2873

Merged
merged 6 commits into from
Aug 27, 2023
Merged

refactor(service/webdav): Add docker-compose file to simplify the CI #2873

merged 6 commits into from
Aug 27, 2023

Conversation

dqhl76
Copy link
Member

@dqhl76 dqhl76 commented Aug 16, 2023 •
edited

part of #2860

@dqhl76
chore: delete debug tag
7eba7d5 
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 changed the title misc(service/webdav): Add docker-compose file to simplify the CI WIP misc(service/webdav): Add docker-compose file to simplify the CI Aug 16, 2023
@dqhl76
fix: empty password
adf1059 
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 changed the title WIP misc(service/webdav): Add docker-compose file to simplify the CI misc(service/webdav): Add docker-compose file to simplify the CI Aug 16, 2023
@dqhl76 dqhl76 changed the title misc(service/webdav): Add docker-compose file to simplify the CI refact(service/webdav): Add docker-compose file to simplify the CI Aug 16, 2023
@Xuanwo Xuanwo changed the title refact(service/webdav): Add docker-compose file to simplify the CI refactor(service/webdav): Add docker-compose file to simplify the CI Aug 16, 2023
@dqhl76
fix: change dir name
f54da6f 
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76
doc: add comment for redirecting docker compose
e81292c 
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@suyanhanx suyanhanx requested a review from Xuanwo August 16, 2023 13:28
@dqhl76
fix: fix misusing of volume
111e694 
Signed-off-by: Liuqing Yue <dqhl76@gmail.com>
@dqhl76 dqhl76 requested a review from Xuanwo August 18, 2023 12:24
@dqhl76
Copy link
Member Author

dqhl76 commented Aug 18, 2023 •
edited

Hi @Xuanwo, Could you please take a look again?

I introduced a Dockerfile to solve the permission problem.

I was not sure if it is the best way to solve that.

@Xuanwo
Copy link
Member

Xuanwo commented Aug 19, 2023

I introduced a Dockerfile to solve the permission problem.

It's more like a upstream bug to me. I prefer to submit an issue to https://github.com/dgraziotin/docker-nginx-webdav-nononsense and fix it there.

We should create the dir and set the permission first before mark it as a volumn.

https://github.com/dgraziotin/docker-nginx-webdav-nononsense/blob/main/Dockerfile#L136-L137

@dqhl76
Copy link
Member Author

dqhl76 commented Aug 19, 2023

Ok. I will open an issue on the upstream later and ask them if I can fix it

@dqhl76 dqhl76 mentioned this pull request Aug 20, 2023
Closed
@dqhl76
Copy link
Member Author

dqhl76 commented Aug 24, 2023

wait for dgraziotin/docker-nginx-webdav-nononsense#95

@dqhl76
Copy link
Member Author

dqhl76 commented Aug 27, 2023

The upstream PR dgraziotin/docker-nginx-webdav-nononsense#95 successfully merged!

@Xuanwo All checks passed. Could you please take a look again? Thanks!
https://github.com/apache/incubator-opendal/actions/runs/5990445081/job/16247756194?pr=2873

Xuanwo
Xuanwo approved these changes Aug 27, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 0e1dabd into apache:main Aug 27, 2023
54 of 58 checks passed
@dqhl76 dqhl76 deleted the docker-webdav branch September 12, 2023 11:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE PsiACE is a code owner

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@dqhl76 @Xuanwo