Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: permission problem with data dir #95

Merged
merged 1 commit into from
Aug 26, 2023

Conversation

dqhl76
Copy link
Contributor

@dqhl76 dqhl76 commented Aug 22, 2023

fix: #94

Create data dir and set the ownership firstly to solve the problem.

I test two cases and both has no problem:

  • mount a dir:
    volumes:
          - ./webdav-data:/data
  • anonymous volume:
    volumes:
          - /webdav-data:/data
volumes:
  webdav-data:

@dqhl76
Copy link
Contributor Author

dqhl76 commented Aug 23, 2023

Hi @dgraziotin, Could you please take a look?

@dgraziotin
Copy link
Owner

dgraziotin commented Aug 23, 2023 via email

Copy link
Owner

@dgraziotin dgraziotin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@dgraziotin dgraziotin merged commit 4a5d19e into dgraziotin:main Aug 26, 2023
@dgraziotin
Copy link
Owner

dgraziotin commented Aug 26, 2023

Thank you for the PR. While I can't test whether this resolves the other issues that I can't reproduce, I reviewed it and tested it, and it does not seem to change anything on the negative. If this change solves the issues you are having downstream, I welcome the change! I merged this before triggering a build for mainline 1.25.2. Once the build is over, you should be able to receive the changes in your pulled images.

@dqhl76
Copy link
Contributor Author

dqhl76 commented Aug 26, 2023

Hi, Thanks for your review!

I'm not quite sure if I understand correctly. You seem revert this change when you triggering a build for mainline 1.25.2: 7612e7d.
Is there any way here that I can directly get an image built from this commit?

@dqhl76 dqhl76 deleted the fix-permission branch August 26, 2023 14:06
@dgraziotin
Copy link
Owner

I screwed something when I pushed, I’m so sorry. It’s night where I’m based at. Let me fix this tomorrow and trigger the build again :-/

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[bug] unexpected 403 error caused by permission setting
2 participants