Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(services): Implement ConfigDeserializer and add S3Config as example #3490

Merged
merged 3 commits into from
Nov 6, 2023
Merged

feat(services): Implement ConfigDeserializer and add S3Config as example #3490

merged 3 commits into from
Nov 6, 2023

Conversation

Xuanwo
Copy link
Member

@Xuanwo Xuanwo commented Nov 6, 2023

Part of #3240

@Xuanwo
FIx on support
f7d1004 
Signed-off-by: Xuanwo <github@xuanwo.io>
@Xuanwo Xuanwo requested a review from suyanhanx November 6, 2023 12:59
@Xuanwo
Add test case
fd8d639 
Signed-off-by: Xuanwo <github@xuanwo.io>
suyanhanx
suyanhanx approved these changes Nov 6, 2023
View reviewed changes
Copy link
Member

@suyanhanx suyanhanx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks

@Xuanwo Xuanwo merged commit 2ef5465 into main Nov 6, 2023
189 checks passed
@Xuanwo Xuanwo deleted the config-refactor branch November 6, 2023 13:25
@Xuanwo Xuanwo mentioned this pull request Nov 6, 2023
Open
47 tasks
@silver-ymz silver-ymz mentioned this pull request Nov 7, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@suyanhanx suyanhanx suyanhanx approved these changes

@PsiACE PsiACE Awaiting requested review from PsiACE

Assignees
No one assigned
Labels
releases-note/feat
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xuanwo @suyanhanx