Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tracking issues of RFC-3197: Config #3240

Open
30 of 47 tasks
Xuanwo opened this issue Oct 8, 2023 · 30 comments
Open
30 of 47 tasks

Tracking issues of RFC-3197: Config #3240

Xuanwo opened this issue Oct 8, 2023 · 30 comments
Labels
good first issue Good for newcomers help wanted Extra attention is needed

Comments

@Xuanwo
Copy link
Member

Xuanwo commented Oct 8, 2023

Notes

This issue intends to add config for every service.

Take #3490 as an example, we just need to move deserialize-able fields (like String, bool, usize) into XxxConfig:

#[derive(Default, Deserialize)]
#[serde(default)]
#[non_exhaustive]
pub struct XxxConfig {
   /// Comments
   pub root: Option<String>,
}

Please note: all fields here should be pub.

And use XxxConfig to replace existing fields:

#[derive(Default)]
pub struct XxxBuilder {
+    config: XxxConfig,
-    root: Option<String>,
-    abc: String,
-    ...

    customed_credential_load: Option<Box<dyn AwsCredentialLoad>>,
    http_client: Option<HttpClient>,
}

Leave fields like http_client as is.

Change the Builder::from_map implemantion to:

- let mut builder = XxxBuilder::default();
- 
- map.get("root").map(|v| builder.root(v));
+ let config = XxxConfig::deserialize(ConfigDeserializer::new(map))
            .expect("config deserialize must succeed");

Tasks

@hoslo
Copy link
Contributor

hoslo commented Nov 6, 2023

I want to try sqlite

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 6, 2023

I want to try sqlite

Thanks a lot, have fun!

@acehinnnqru
Copy link
Contributor

I want to try azblob

@sd44
Copy link
Contributor

sd44 commented Nov 7, 2023

I want to try Postgresql

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 7, 2023

I want to try azblob

Have fun!

I want to try Postgresql

Have fun too!

@sd44
Copy link
Contributor

sd44 commented Nov 7, 2023

I want to try Mysql and Libsql

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 7, 2023

I want to try Mysql and Libsql

Hi, let's take issues one by one instead trying to take places. How about taking mysql first?

@hoslo
Copy link
Contributor

hoslo commented Nov 7, 2023

I want to try sqlite

request assign redis

@caicancai
Copy link
Member

i want to try tikv

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 7, 2023

i want to try tikv

Thanks! Have fun.

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 7, 2023

Thank you for all your passion! There's no rush on this tracking issue, and I'd like it to be the first task for contributors. Once you've completed a task, please move onto others so we can involve more people in this event.

@xiaoyang-sde
Copy link
Member

First-time contributor here! I'd like to take a look at the CloudflareKv service.

@Xuxiaotuan
Copy link
Contributor

i want to try etcd

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 8, 2023

i want to try etcd

Thanks a lot, have fun!

@cjj2010
Copy link
Contributor

cjj2010 commented Nov 8, 2023

i want to try Rocksdb

@Xuanwo
Copy link
Member Author

Xuanwo commented Nov 8, 2023

i want to try Rocksdb

Have fun!

@shbhmrzd
Copy link
Contributor

I want to try Fs

@ankit-pn
Copy link
Contributor

hey i want to try memcached and rocksdb. it seems @cjj2010 is already working on rocksdb, so maybe i can work with him on it. it would be great if you assign memcached to me.
thanks.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 23, 2023

hey i want to try memcached and rocksdb. it seems @cjj2010 is already working on rocksdb, so maybe i can work with him on it. it would be great if you assign memcached to me. thanks.

Thanks, assigned.

@ankit-pn
Copy link
Contributor

I would also like to work on gdrive and ipfs.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 27, 2023

Thank you for all your passion! There's no rush on this tracking issue, and I'd like it to be the first task for contributors. Once you've completed a task, please move onto others so we can involve more people in this event.

Hi, Thank you for all your passion! There's no rush on this tracking issue, and I'd like it to be the first task for contributors. How about moving onto others so we can involve more people in this event?

@ankit-pn
Copy link
Contributor

Sure, I will look into other issues and try to contribute there. I would be better off leaving this issue for newcomers. Thanks.

@k-aishwarya
Copy link
Contributor

Hi, I would like to work on Atomicserver.

@Xuanwo
Copy link
Member Author

Xuanwo commented Dec 28, 2023

Hi, I would like to work on Atomicserver.

Thanks a lot! Welcome.

@zjregee
Copy link
Contributor

zjregee commented Jan 3, 2024

i want to try mongodb.

@howiieyu
Copy link
Contributor

howiieyu commented Jan 9, 2024

I would like to work on dropbox.

@Xuanwo
Copy link
Member Author

Xuanwo commented Jan 9, 2024

I would like to work on dropbox.

Thanks, assigned!

howiieyu added a commit to howiieyu/incubator-opendal that referenced this issue Jan 9, 2024
Part of apache#3240

Signed-off-by: HowiieYu <howiieyu@gmail.com>
Xuanwo pushed a commit that referenced this issue Jan 10, 2024
* refactor(service/dropbox): Add DropboxConfig

Part of #3240

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* chore(dropbox): apply fmt and clippy

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* chore: apply fmt

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* feat(dropbox): make DropboxConfig public

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* doc(dropbox): add doc for DropboxConfig

Signed-off-by: HowiieYu <howiieyu@gmail.com>

---------

Signed-off-by: HowiieYu <howiieyu@gmail.com>
hoslo pushed a commit to hoslo/incubator-opendal that referenced this issue Jan 10, 2024
* refactor(service/dropbox): Add DropboxConfig

Part of apache#3240

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* chore(dropbox): apply fmt and clippy

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* chore: apply fmt

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* feat(dropbox): make DropboxConfig public

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* doc(dropbox): add doc for DropboxConfig

Signed-off-by: HowiieYu <howiieyu@gmail.com>

---------

Signed-off-by: HowiieYu <howiieyu@gmail.com>

feat(services/webhdfs): Implement multi write via CONCAT

feat(services): add multi write for webhdfs via CONCAT

feat(services/webhdfs): Implement multi write via CONCAT
hoslo pushed a commit to hoslo/incubator-opendal that referenced this issue Jan 10, 2024
author Xuanwo <github@xuanwo.io> 1704791346 +0800
committer hoslo <ys952572463@gmail.com> 1704869738 +0800

refactor!: Revert the bump of MSRV to 1.75 (apache#3952)

Revert "refactor!: Bump MSRV to 1.75 (apache#3851)"

This reverts commit 3edaa8f.

fix: Don't retry close if concurrent > 1 to avoid content lost (apache#3957)

* Fix build

Signed-off-by: Xuanwo <github@xuanwo.io>

* Fix

Signed-off-by: Xuanwo <github@xuanwo.io>

---------

Signed-off-by: Xuanwo <github@xuanwo.io>

feat(services/webhdfs): Implement multi write via CONCAT

refactor(services/onedrive): Add OnedriveConfig to implement ConfigDeserializer (apache#3954)

refactor(service/dropbox): Add DropboxConfig (apache#3961)

* refactor(service/dropbox): Add DropboxConfig

Part of apache#3240

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* chore(dropbox): apply fmt and clippy

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* chore: apply fmt

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* feat(dropbox): make DropboxConfig public

Signed-off-by: HowiieYu <howiieyu@gmail.com>

* doc(dropbox): add doc for DropboxConfig

Signed-off-by: HowiieYu <howiieyu@gmail.com>

---------

Signed-off-by: HowiieYu <howiieyu@gmail.com>

feat(services/webhdfs): Implement multi write via CONCAT

feat(services/webhdfs): Implement multi write via CONCAT
jihuayu added a commit to jihuayu/opendal that referenced this issue Feb 2, 2024
jihuayu added a commit to jihuayu/opendal that referenced this issue Feb 2, 2024
Xuanwo pushed a commit that referenced this issue Feb 2, 2024
* Add D1Config #3240

* Add D1Config #3240

* format code

* fix bug

* fix cargo clippy
@yufan022
Copy link
Contributor

let my try the sled

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers help wanted Extra attention is needed
Projects
None yet
Development

No branches or pull requests