Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(service/etcd): Add EtcdConfig to implement ConfigDeserializer #3543

Merged
merged 6 commits into from
Nov 9, 2023
Merged

refactor(service/etcd): Add EtcdConfig to implement ConfigDeserializer #3543

merged 6 commits into from
Nov 9, 2023

Conversation

Xuxiaotuan
Copy link
Contributor

Part of #3240

Xuanwo
Xuanwo reviewed Nov 9, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Mostly LGTM, thanks!

core/src/services/etcd/backend.rs Outdated Show resolved Hide resolved
Xuanwo
Xuanwo approved these changes Nov 9, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@Xuanwo Xuanwo merged commit 60b4d3a into apache:main Nov 9, 2023
36 checks passed
@Xuanwo Xuanwo mentioned this pull request Nov 9, 2023
Open
47 tasks
@G-XD G-XD mentioned this pull request Nov 27, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@Xuxiaotuan @Xuanwo