Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(services/webdav): Add WebdavConfig to implement ConfigDeserializer #3846

Merged
merged 2 commits into from
Dec 30, 2023
Merged

refactor(services/webdav): Add WebdavConfig to implement ConfigDeserializer #3846

merged 2 commits into from
Dec 30, 2023

Conversation

kwaa
Copy link
Contributor

@kwaa kwaa commented Dec 28, 2023

Part of #3240

@kwaa kwaa requested a review from Xuanwo as a code owner December 28, 2023 13:28
Xuanwo
Xuanwo reviewed Dec 29, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Others LGTM, thanks a lot!

core/src/services/webdav/backend.rs Show resolved Hide resolved
core/src/services/webdav/backend.rs Outdated Show resolved Hide resolved
@Xuanwo Xuanwo mentioned this pull request Dec 29, 2023
Open
47 tasks
@kwaa kwaa requested a review from Xuanwo December 29, 2023 05:55
@kwaa kwaa force-pushed the services/webdav branch 2 times, most recently from 172f2ad to e97bd8a Compare December 29, 2023 16:14
@kwaa
Copy link
Contributor Author

kwaa commented Dec 30, 2023

@Xuanwo Can you review this PR again?

Xuanwo
Xuanwo approved these changes Dec 30, 2023
View reviewed changes
Copy link
Member

@Xuanwo Xuanwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! You can migrate the impl Builder for Webdav via ConfigDeserializer in next PR.

@Xuanwo Xuanwo merged commit ad8c51a into apache:main Dec 30, 2023
43 checks passed
@Xuanwo Xuanwo mentioned this pull request Dec 31, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Xuanwo Xuanwo Xuanwo approved these changes

Assignees
No one assigned
Labels
releases-note/refactor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kwaa @Xuanwo