Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

updated some licenses to ASF and removed naxsi module #293

Merged
merged 3 commits into from
May 7, 2018

Conversation

ddragosd
Copy link
Contributor

@ddragosd ddragosd commented May 4, 2018

This issue relates to #288.

Changes:

  • Updated files containing Adobe's MIT license to Apache 2.0 license
  • Removed NAXSI lib b/c it's GPL licensed and it can't be included in Apache licensed projects.

@ddragosd
Copy link
Contributor Author

ddragosd commented May 5, 2018

I see the build fails with

Unsupported parameters for (docker_container) module: userns_mode

This is not related to the changes in the current PR, but rather an ansible module issue; I’ll check for a fix regardless, early next week.

@mhamann
Copy link
Member

mhamann commented May 5, 2018

Yeah, I started to look into it, but ran out of time. If you get time, that'd be great.

@csantanapr
Copy link
Member

I think is a problem with recent change to update to ansible 2.5
Update tools/travis/setup.sh and is better to use the setup.sh from core repo that way we don’t have to install ansible from this repo

@ddragosd
Copy link
Contributor Author

ddragosd commented May 7, 2018

thanks @csantanapr I'll give it a try now.

@ddragosd
Copy link
Contributor Author

ddragosd commented May 7, 2018

solved the build issues in #295 . @mhamann , @csantanapr may I ask for your help to review that one ?

@ddragosd ddragosd added the apache label May 7, 2018
@ddragosd
Copy link
Contributor Author

ddragosd commented May 7, 2018

Update tools/travis/setup.sh and is better to use the setup.sh from core repo that way we don’t have to install ansible from this repo

@csantanapr I'm wondering how we can implement this in the sub-projects such as this one. Have the setup clone the entire https://github.com/apache/incubator-openwhisk and run the setup.sh from it first ?

@ddragosd ddragosd merged commit 973c048 into apache:master May 7, 2018
@ddragosd ddragosd deleted the issue_288 branch May 7, 2018 22:36
@csantanapr
Copy link
Member

Yes we already cloning the main repo we just need to use setup.sh from it

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants