For Ease of Maintenance, Update and Decide Where these Tests Should Live

[drcariel]

There is currently a level of manual syncing going on between duplicate test files that exist in both https://github.com/apache/incubator-openwhisk-cli and https://github.com/apache/incubator-openwhisk. I noticed the following files, sharing the same name unless indicated otherwise, that could use further investigation and/or updating:

• ApiGwEndToEndTests.scala
• WskActionTests.scala
• WskBasicJavaTests.scala
• WskBasicNodeTests.scala (Moved CLI versions from open to cli)
• WskBasicPythonTests.scala
• WskBasicSwift3Tests.scala
• WskCliBasicNodeTests.scala (WskCliBasicNodeDefaultTests.scala and extended in other files to use both node 6 and 8)
• WskConsoleTests.scala
• WskPackageTests.scala
• WskRuleTests.scala (diverged by 10 lines)
• WskSequenceTests.scala
• ApiGwRoutemgmtActionTests.scala
• BaseApiGwTests.scala
• JsonArgsForTests.scala (changed to depend on TestJsonArgs.scala in open)
• WskActionSequenceTests.scala
• WskEntitlementTests.scala
• WskWebActionsTests.scala (diverged by 6 lines)
• ApiGwTests.scala (renamed to indicate rest vs cli in respective repos)
• WskBasicUsageTests.scala (renamed to indicate rest vs cli in respective repos)
• WskBasicTests.scala (renamed to indicate rest vs cli in respective repos)

Updating the test builds to rely on the original copies of most of the above that exist in incubator-openwhisk will be much easier to maintain. Which tests belong in this repo and vice versa?

[mdeuser]

@drcariel - thanks for the details. are these files identical between the two repos or is there some change made when merging into the open cli repo?

[drcariel]

It seems to me that they are intended to be identical, however some seem to have diverged, as mentioned in my list above. There may be more divergences as I have only glanced at all the tests that seem identical at first.

[drcariel]

I will be working to remove the baseWsk versions from open-cli since we have the sources provided via openwhisk maven jar deps

[drcariel]

See the above PRs ☝️ , I have done my best to get the "low hanging fruit" of the lot. The 3 remaining; WskBasicTests.scala, ApiGwTests.scala, and WskBasicUsageTests.scala need some more work to get done right. ApiGw needs to be merged as it has diverged quite a bit and both of the others need to be centralized to use baseWsk then extended.

[mdeuser]

@drcariel - when a file in the description has been striked through, what does that mean? .. that the file will now be picked up from the incubator-openwhisk repo and deleted from the incubator-openwhisk-cli repo?

[drcariel]

Exactly Mark, If striken through, I have been able to merge any divergent tests and move to extend the single baseWsk version from incubator-openwhisk(a bit of my own personal checklist to track the progress). The only cases that are a bit different are the node test changes where I do the opposite; move the CLI node tests from incubator-openwhisk -> incubator-openwhisk-cli

[mdeuser]

ah.. ok. you might want to use the markdown checkboxes to track that kind of work instead of strikethroughs

• put an 'x' in here when done :-)

[drcariel]

Closed via #3531