Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Track LICENSE and NOTICE issues for incubator-openwhisk-wskdeploy #94

Closed
mrutkows opened this issue Apr 9, 2018 · 4 comments
Closed

Comments

@mrutkows
Copy link
Contributor

mrutkows commented Apr 9, 2018

Please use this issue to track any issues surrounding either the LICENSE.txt or NOTICE.txt file for the associated repository listed in the title.

Open Issues/PRs:

Closed Issues/Merged PRs:

PRs Closed/Reverted/Revisit:

@mrutkows
Copy link
Contributor Author

mrutkows commented Apr 9, 2018

@daisy-ycguo @houshengbo Addressing the discussion in PR apache/openwhisk-wskdeploy#844 (review), we have need to document that we have decided not to include the generated "i18n_resources.go" file and are unable to add a header comment to its source input file (i.e., en_US.all.json or other similar language/country coded JSON files).

IMO, we should include this decision/logic in this repo's LICENSE file.

@daisy-ycguo
Copy link
Member

daisy-ycguo commented Apr 17, 2018

Issue was created to track the header issue: apache/openwhisk-wskdeploy#716, and also a PR was merged apache/openwhisk-wskdeploy#709.

Yet there is still a TODO: change the test files to short license header.

@daisy-ycguo
Copy link
Member

I submitted a PR to add headers to the left 3 files apache/openwhisk-wskdeploy#883. This should be the last PR, I think. After it gets merged, there should be no files missing header in wskdeploy repo.

@mrutkows mrutkows changed the title Document LICENSE file Exclusions for incubator-openwhisk-wskdeploy Track LICENSE and NOTICE issues for incubator-openwhisk-wskdeploy May 17, 2018
@houshengbo
Copy link

We can close this issue, since all the PRs have been merged.
The issue #175 is being fixed by another PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants