Add the fundamental framework of REST invocation for test cases

[houshengbo]

Almost all the test cases in OpenWhisk are currently running based
on the wsk CLI binary. In order to separate the CLI out of OpenWhisk
core repository, we need to call REST API of OpenWhisk to access
OpenWhisk services instead of calling the wsk CLI binary command.

This PR adds the basic REST implementation for all the test cases
to use. One basic principle is to keep the changes to the existing
test cases as few as possible, so we add WskRest.scala as an equivalent
class to Wsk.scala and WskRestTestHelpers.scala as an equivalent file
to WskTestHelpers.scala for REST.

All the replacement of binary with REST will happen in an increamental fashion.
This PR only changes one existing test case in WskActionTests.scala, and
reimplements it in WskRestActionTests.scala. All the other test cases can follow
the same way to change the test cases one by one. New changes may be necessary
to the basic REST implementation as well in future to accommodate the test cases.

Partially-closes-bug: #2430

[markusthoemmes]

Close #2480 ?

[dubee]

I think this function can be named more appropriately as it looks like invokeAction will handle all CRUD requests for actions.

[houshengbo]

invokeaction only invokes actions by POST the existing action. This name should be fine.

[dubee]

Shouldn't need this as kind is defined as a Some or None.

[houshengbo]

Done

[dubee]

Match on Some or None here for kind. Ex:

kind match {
	case Some(k) if k == "copy" => copy routine
	case Some(k) if k == "sequence" => sequence routine
	case _ => kind is None
}

[houshengbo]

Done

[dubee]

How would feed be null here if it is a Some or None?

[houshengbo]

It should be feedInput, but I will change part anyway.

[dubee]

Shouldn't need this, just match on feed like example I left above.

[houshengbo]

Done

[dubee]

"0" is already a string. Shouldn't need to use toString there.

[houshengbo]

Done.

[dubee]

Newline here needed?

[houshengbo]

removed.

[dubee]

Possible to get rid of null on these new RestResult calls?

[houshengbo]

done.

[dubee]

Here you can do shared.getOrElse(false).

[houshengbo]

done

[dubee]

Here you can do shared.getOrElse(false).

[houshengbo]

done

[dubee]

Here you can do shared.getOrElse(false).

[houshengbo]

done

[dubee]

Here it looks like the an empty string returns Some(). I think None should be returned instead.

[dubee]

Should only need this in the function:

Try {
     if ((result.statusCode == OK) || (result.statusCode == Accepted)) Some(result.getField("activationId")) else None
}

[houshengbo]

We should remove try {}, or it will report error.

[dubee]

triggerName != an action name.

[houshengbo]

I renamed the function into getNamespaceEntityName, cos it is more appropriate.

[dubee]

packageName != action name.

[houshengbo]

I renamed the function into getNamespaceEntityName, cos it is more appropriate.

[dubee]

Is this equivalent?

def getNamespaceAndEntityName(name: String)(implicit wp: WskProps): (Option[String], Option[String]) = {
	name.split("/") match {
		case Array(empty, namespace, entityName) if empty.isEmpty => (Some(namespace), Some(entityName))
		case Array(empty, namespace) if empty.isEmpty => (Some(namespace), None)
		case Array(entityName) => (Some(wp.namespace), Some(entityName))
		case _ => (None, None)
	}
}

[dubee]

Maybe throw an error on _ case. What do you think?

[houshengbo]

Let me see how to rewrite it.
There is no need to do case _ => (None, None), or even return errors, because the worst case is to return wp.namespace and name.

[dubee]

Both toString calls are not needed here.