Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Create test cases based on Wsk REST and REST entities #2480

Closed
wants to merge 1 commit into from
Closed

Create test cases based on Wsk REST and REST entities #2480

wants to merge 1 commit into from

Conversation

houshengbo
Copy link

@houshengbo houshengbo commented Jul 13, 2017 •
edited

Partially-closes-bug: #2430

@houshengbo houshengbo force-pushed the rest-client branch 16 times, most recently from 96c1fd3 to ab1e968 Compare July 19, 2017 21:57
@houshengbo houshengbo changed the title WIP: Implement REST for test cases to replace wsk binary WIP: Add the fundamental framework of REST invocation for test cases to replace wsk binary Jul 20, 2017
@houshengbo houshengbo force-pushed the rest-client branch 9 times, most recently from 8989bd4 to 981c704 Compare July 21, 2017 21:21
@rabbah rabbah changed the title WIP: Add the fundamental framework of REST invocation for test cases to replace wsk binary Add the fundamental framework of REST invocation for test cases to replace wsk binary Jul 23, 2017
@houshengbo houshengbo force-pushed the rest-client branch 10 times, most recently from aab5ef6 to a26bf57 Compare August 2, 2017 21:13
@houshengbo houshengbo force-pushed the rest-client branch 14 times, most recently from 62bca34 to c833f32 Compare August 8, 2017 19:03
@markusthoemmes markusthoemmes mentioned this pull request Aug 8, 2017
Merged
Add the fundamental framework of REST invocation for test cases to re…
b6e4dcd 
…place wsk binary

Almost all the test cases in OpenWhisk are currently running based
on the wsk CLI binary. In order to separate the CLI out of OpenWhisk
core repository, we need to call REST API of OpenWhisk to access
OpenWhisk services instead of calling the wsk CLI binary command.

This PR adds the basic REST implementation for all the test cases
to use. One basic principle is to keep the changes to the existing
test cases as few as possible, so we add WskRest.scala as an equivalent
class to Wsk.scala and WskRestTestHelpers.scala as an equivalent file
to WskTestHelpers.scala for REST.

All the replacement of binary with REST will happen in an increamental fashion.
This PR only changes one existing test case in WskActionTests.scala, and
reimplements it in WskRestActionTests.scala. All the other test cases can follow
the same way to change the test cases one by one. New changes may be necessary
to the basic REST implementation as well in future to accommodate the test cases.
@houshengbo houshengbo mentioned this pull request Aug 9, 2017
Closed
@houshengbo houshengbo changed the title Add the fundamental framework of REST invocation for test cases to replace wsk binary Create test cases based on Wsk REST and REST entities Aug 9, 2017
@houshengbo houshengbo closed this Aug 15, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
cli wip
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
1 participant
@houshengbo