-
Notifications
You must be signed in to change notification settings - Fork 1.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ansible playbooks for deploying each of the providers #2622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this but I'm wondering: Why do we want to centralize these deployments? The providers are each self contained. We have strived to keep the core deployment minimal.
Further without testing these integrations they will rot. And if we test them as part of normal CI they will make the build dramatically longer.
What's the rationale here and should these playbook be consolidated elsewhere (like in devtools for example) instead.
cc @jasonpet |
This follows the pattern that was done for openwhisk-catalog. Travis tests inside the provider repos will be using these ansible updates. So to answer the question above, tests will be running regularly that make use of this and they will not affect the build time for this repo since they will be running elsewhere. We can talk further about whether the pattern we had been using is the right one, but I do not want lots of ansible code duplication (environments for example) in many different repos. |
This integration would be same as we have today for catalog. I will mark this PR as The CI will look similar as catalog:
I agree maybe there is an optimal way to this with ansible but we would also do it for catalog, and push. Right now I don't what's best practice in terms of ansible distributed structure. I would prefer to make progress and this will allow for individual repos to have CI/Travis integration, and also allow something like vagrant to deploy alarms |
questions:
|
There's also a big difference between the catalog which are a couple of handful of actions vs deploying these providers which deploy containers requiring more memory from a vm. Further if the CI for these playbook are tested separately why put it in this repo at all. |
Answer to number 1 and 2 is no. Providers depend on this repo, but this repo has no dependency on them. A separate playbook would have to be run to deploy providers. Number 3 is definitely something that should be further discussed. |
The only reason it was put here was to reuse the ansible infrastructure. I guess we could duplicate some of this and put it in the dev tool repo. I am not at all familiar with the dev tool repo |
Using the dev tools repo would create another dependency for the provider repos though. They already have a dependency on this one for the test utils. |
I think we are going to wait on doing this and do it the kube way, closing for now |
No description provided.