Measure kafka queue in consumer with better exactitude #3423
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rabbah
reviewed
Mar 12, 2018
| consumer.poll(duration.toMillis).map(r => (r.topic, r.partition, r.offset, r.value)) | ||
| val response = consumer.poll(duration.toMillis).map(r => (r.topic, r.partition, r.offset, r.value)) | ||
| response.lastOption.foreach { | ||
| case (_, _, newOffset, _) => offset = newOffset + 1 |
There was a problem hiding this comment.
Can you fold this into the previous map instead?
There was a problem hiding this comment.
Do you mean updating the offset each time new message arrives?
vvraskin
force-pushed
the
kafka_queue_update
branch
from
0fd304c
to
408f031
Compare
vvraskin
force-pushed
the
kafka_queue_update
branch
from
408f031
to
84eee72
Compare
markusthoemmes
approved these changes
Mar 13, 2018
rabbah
approved these changes
Mar 13, 2018
BillZong
pushed a commit
to BillZong/openwhisk
that referenced
this pull request
Nov 18, 2019
Measure kafka queue metric directly in the consumer by comparing the offsets instead of relying on the built-in consumer metrics. This method provides more precision compared to the old approach, it was observed that the built-in metrics show certain lagging in case of burst. Additionally make kamon flush cadency configurable in the application.conf.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Measure kafka queue metric directly in the consumer by comparing the offsets instead of relying on the built-in consumer metrics. This method provides more precision compared to the old approach, it was observed that the built-in metrics show certain lagging in case of burst.
Additionally make kamon flush cadency configurable in the application.conf.
My changes affect the following components
Types of changes