Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support Brotli as an encoding scheme when client has Accept-Encoding #1148

Open
jmarantz opened this issue Oct 1, 2015 · 10 comments
Open

Support Brotli as an encoding scheme when client has Accept-Encoding #1148

jmarantz opened this issue Oct 1, 2015 · 10 comments

Comments

@jmarantz
Copy link
Contributor

@jmarantz jmarantz commented Oct 1, 2015

See https://code.google.com/p/chromium/issues/detail?id=452335 which tracks Chrome support for Brotli in https.

Mozilla has already added support: https://bugzilla.mozilla.org/show_bug.cgi?id=366559

@igrigorik

This comment has been minimized.

Copy link

@igrigorik igrigorik commented Oct 2, 2015

👍

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

@jeffkaufman jeffkaufman commented Oct 23, 2015

Current plan for this:

  • @crowell is adding support for caching encoded resources, starting with gzip
  • once there's good browser support we'll look at extending that to include brotli compression
@crowell

This comment has been minimized.

Copy link
Contributor

@crowell crowell commented Jan 27, 2016

caching gzip-encoded resources is in with 1.10.33.0 and newer
brotli support is started here https://github.com/pagespeed/mod_pagespeed/blob/master/pagespeed/kernel/util/brotli_inflater.h
but after profiling, the current version of brotli (0.3.0) is too memory intensive in encoding to comfortably deploy.
this will be revisited in the future when brotli becomes more efficient at encoding.

@jeffkaufman

This comment has been minimized.

Copy link
Contributor

@jeffkaufman jeffkaufman commented Apr 7, 2016

Brotli resource usage at level 10 should now be low enough that we'd be able to do this.

On the other hand, @crowell's initial investigation suggests this is more work to integrate than we had thought (on our end), so we've needed to bump the priority down here some.

@quixote911

This comment has been minimized.

Copy link

@quixote911 quixote911 commented Jun 23, 2016

Brotli 0.4.0 is out - https://github.com/google/brotli/releases

Any plans to re-evaluate how 0.4.0 does with mod_pagespeed?

@jmarantz

This comment has been minimized.

Copy link
Contributor Author

@jmarantz jmarantz commented Jun 23, 2016

Based on the numbers we've seen, Brotli is now in good enough shape we can
deploy it. However we are pretty tight on human resources now and it is
feasible but somewhat complex for us to cache alternate encodings for
different browsers.

We definitely want to do it and believe it will help by reducing network
bandwidth by up to 20% for CSS and JS. It simply competes with other
optimizations and bug fixes we want to do.

On Thursday, June 23, 2016, Ankit Arora notifications@github.com wrote:

Brotli 0.4.0 is out - https://github.com/google/brotli/releases

Any plans to re-evaluate how 0.4.0 does with mod_pagespeed?


You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
#1148 (comment),
or mute the thread
https://github.com/notifications/unsubscribe/AB2kPd9cW8VNf1CPqrrMiFi0PFG17WXgks5qOl9agaJpZM4GHrKA
.

@timeassistant

This comment has been minimized.

Copy link

@timeassistant timeassistant commented Oct 8, 2018

Hello,

Just wondering if Brotli support was ever managed? Would love to be able to serve brotli compressed files over gzip :)

@GuillaumeRossolini

This comment has been minimized.

Copy link

@GuillaumeRossolini GuillaumeRossolini commented Oct 8, 2018

@timeassistant in case you are interested in a fallback, recent versions of httpd support Brotli out of the box (v2.4.26 and up).

@timeassistant

This comment has been minimized.

Copy link

@timeassistant timeassistant commented Oct 11, 2018

@GuillaumeRossolini thanks, I already have the brotli module enabled. I was just curious if pagespeed was able to use brotli aswell

@tomayac

This comment has been minimized.

Copy link
Contributor

@tomayac tomayac commented Jan 24, 2020

While we wait for native support (🙏 thanks in advance to everyone involved in this effort), I've just documented how to make the current PageSpeed work with Brotli.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
8 participants
You can’t perform that action at this time.