Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rewrite CSS in <tag style="..."> #249

Closed
GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments
Closed

Rewrite CSS in <tag style="..."> #249

GoogleCodeExporter opened this issue Apr 6, 2015 · 4 comments

Comments

@GoogleCodeExporter
Copy link

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

See http://www.capitalwines.com.au/, which specifies images like:

<td style="background: url(/images/menu_left_bg.jpg) right repeat-y;">

This CSS is not minified and the images are not rewritten. It shouldn't be too 
hard to rewrite them.

Original issue reported on code.google.com by sligocki@google.com on 22 Mar 2011 at 2:04

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Thanks.  Would be great if the CSS backgrounds could also be data-ified 
(inlined) as per other images when they're less than 
ModPagespeedImgInlineMaxBytes :)

Original comment by dun...@chirp.com.au on 22 Mar 2011 at 2:16

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

We've got that as http://code.google.com/p/modpagespeed/issues/detail?id=240

Original comment by sligocki@google.com on 22 Mar 2011 at 2:29

@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

It's easier to do the data: inlining in this case since we don't need to worry 
about having a separate URL when not supported, though. 

(Anyway, mostly just fly-by fixing the title so it doesn't confuse me.)


Original comment by morlov...@google.com on 22 Mar 2011 at 2:32

  • Changed title: Rewrite CSS in
@GoogleCodeExporter
Copy link
Author

@GoogleCodeExporter GoogleCodeExporter commented Apr 6, 2015

Fixed by Matt.

Original comment by sligocki@google.com on 18 Oct 2011 at 2:15

  • Changed state: Fixed
  • Added labels: release-note
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Linked pull requests

Successfully merging a pull request may close this issue.

None yet
1 participant
You can’t perform that action at this time.