Add <code> to sensitive tags in collapse_whitespace_filter. #1774
Conversation
Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). 📝 Please visit https://cla.developers.google.com/ to sign. Once you've signed (or fixed any issues), please reply here (e.g. What to do if you already signed the CLAIndividual signers
Corporate signers
|
@@ -39,7 +39,7 @@ namespace { | |||
// Tags within which we should never try to collapse whitespace (note that this | |||
// is not _quite_ the same thing as kLiteralTags in html_lexer.cc): | |||
const HtmlName::Keyword kSensitiveTags[] = { | |||
HtmlName::kPre, HtmlName::kScript, HtmlName::kStyle, HtmlName::kTextarea | |||
HtmlName::kCode, HtmlName::kPre, HtmlName::kScript, HtmlName::kStyle, HtmlName::kTextarea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
very cool. Could you also add a test in collapse_whitespace_filter_test.cc? The pattern should be fairly obvious there.
CLAs look good, thanks! |
Nice, thanks! |
@oschaaf do you know why CI is failing? I re-started it once, but both attempts ended in: ld/apache/incubator-pagespeed-mod/third_party/giflib/src'... I'll try a third time. If that fails we can I guess patch/build/test and then merge, but I wanted to see if you thought the CI was failing like this generally and if we should so something about that. |
@jmarantz I noticed the same with another PR lately, but have not investigated yet. perhaps one of the dependencies broke, I’ll take a look later today |
So the test failed on |
We should separately address our CI issues. In the meantime, I patched this change and confirmed it passes its own test...running checkin.make now. Shall we just go ahead & merge? |
@jmarantz +1 for merging With regard to giflib, that started failing when sourceforge starting migrating [1] 8196fc7 |
Fixes #1772