This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Update to Envoy ff49762696b2e6ed3f408a22e1f7a1b7d2487318 (Oct 11th) #2104
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add pagespeed.bazelrc with our modifications so that our .bazelrc will be identical to Envoy's
- Note: needed to define ABSL_LEGACY_THREAD_ANNOTATIONS. Looks like some of absl's annotations have been renamed - fmt started complaining about StringPiece as an input. Needed to tweak logging and introduce some tech debt to strip newlines at the end of the log line without adding memory copying
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Looks like some of absl's annotations have been renamed
Needed to tweak logging and introduce some tech debt to
strip newlines at the end of the log line without adding
memory copying
close to Envoy's as possible.