-
Notifications
You must be signed in to change notification settings - Fork 364
Duplicate Location headers after 302 redirects #1099
Comments
Oh wait, but 01e458c was added fairly recently and is not available in |
Otto noticed that 059dd20 didn't make it into 1.10 because it was merged to the wrong place. That's probably it. |
Hoping for it. Thanks! |
@HansVanEijsden Would you be able to try cherry-picking 059dd20 to verify that this fixes it? |
@jeffkaufman I would love to, but I can't find the instructions on how to install from source. |
Sorry about that! Here's up to date instructions for building from git: Where it says:
Instead do:
Then after you do
Now's the place for the cherry-pick:
And then continue on with the rest of the build, starting with |
No need to say Sorry Jeff. I never asked about it before. 😉 Unfortunately I encounter some errors. I tried to correct them as far as possible, but I'm stuck at doing the right git checkout. Here are the steps I've done (system language is in Dutch, nl_NL, sorry): hans@vps: |
Whoops, I had a typo. Instead of:
you should have
|
Good news: I love those cherry-picks! 😄 $ curl -I https://www.fundays.nl/ In Safari, Wordpress logins and all the other stuff is also working again like it should. |
the git checkout release-1.10.33.2-beta On Fri, Jan 22, 2016 at 4:06 PM, Hans van Eijsden notifications@github.com
Jeff Crowell |
@jeffkaufman I think we should test for duplicates of some headers so we make sure we don't regress, some of the header manipulation in nginx is excessively tricky. Should I create a new issue for that? |
awesome, thanks for testing! On Fri, Jan 22, 2016 at 4:31 PM, Hans van Eijsden notifications@github.com
Jeff Crowell |
Fixed by 059dd20 |
Do have to clear pagespeed Filecache that the fix is working for me? |
@macbobby I do not think so, what kind of trouble are you having? Do you have a url? |
@macbobby which ngx_pagespeed & nginx version? |
OK, had a bug while downloading correct version. Worked vor me now. |
@macbobby Thanks for confirming |
After doing a 302 redirect, browsers like Safari Desktop and Safari Mobile can't display the page. Probably because of duplicate Location headers.
The problem also occurs after trying to login to Wordpress, RoundCube webmail or Joomla (all of those give redirects after a successful login).
To replicate:
Tested with ngx_pagespeed 1.10.33.2-7600 on Nginx 1.9.9.
Basic Nginx config (without Pagespeed parts): http://pastebin.com/FtDdGTeX
If you need the Pagespeed config parts, just let me know. The problem also occurs with all the Pagespeed filters disabled (but Pagespeed loaded of course).
More info: https://groups.google.com/forum/#!topic/pagespeed-dev/0JG3fqFUaWw
The text was updated successfully, but these errors were encountered: