This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Unbreak install after repo transfers #1523
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The directory name in the zip we download from github's release archive will be different now that the project was renamed. It may be renamed again in the future, so try to obtain the directory name from the zip. Fixes #1521
jmarantz
approved these changes
Jan 8, 2018
scripts/build_ngx_pagespeed.sh
Outdated
| @@ -612,7 +612,8 @@ Not deleting $directory; name is suspiciously short. Something is wrong." | |||
| nps_downloaded="$TEMPDIR/$nps_downloaded_fname.zip" | |||
| status "Downloading ngx_pagespeed..." | |||
| run wget "$nps_baseurl/$tag_name.zip" -O "$nps_downloaded" | |||
| nps_module_dir="$BUILDDIR/$nps_downloaded_fname" | |||
| nps_module_dir=$(unzip -qql "$nps_downloaded" | head -n1 | tr -s ' ' | cut -d' ' -f5-) | |||
There was a problem hiding this comment.
would be nice to add a comment indicating what this pipe transformation is expected to do.
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The directory name in the zip we download from github's release
archive will be different now that the project was renamed.
It may be renamed again in the future, so try to obtain the directory
name from the zip.
Fixes #1521