This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Dockerfiles for Alpine 3.8/edge build with Nginx 1.14/1.15 (stable/ma… #1598
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…inline), (directory structure organised for DockerHub build compatibility). Alpine Linux is a security-oriented, lightweight Linux distribution based on musl libc and busy box. Alpine is therefor the most logical OS base for Docker Images. Although it does not fix #1181 completely, it helps to overcome the problems of building the PSOL on Alpine,
jmarantz
approved these changes
Oct 2, 2018
oschaaf
approved these changes
Oct 3, 2018
|
Re: "Should we also go ahead & upgrade the trunk to png 1.6 to avoid having to do this patch?" |
|
(actually, mps already has libpng 1.6 on the bleeding edge version: https://github.com/apache/incubator-pagespeed-mod/tree/master/third_party/libpng) |
|
Maybe we should also link to the readme in https://github.com/apache/incubator-pagespeed-ngx/blob/master/README.md, and the docs (a new page over at https://www.modpagespeed.com/doc)? |
This was referenced Oct 8, 2018
Open
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…inline), (directory structure organised for DockerHub build compatibility).
Alpine Linux is a security-oriented, lightweight Linux distribution based on musl libc and busy box. Alpine is therefor the most logical OS base for Docker Images.
Although it does not fix #1181 completely, it helps to overcome the problems of building the PSOL on Alpine,