This repository has been archived by the owner on Apr 21, 2023. It is now read-only.
Fixes for NGINX nginx 1.23.0 #1750
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
As of nginx 1.23 the cache control headers are re-implemented as al linked list. This reworks our code that manipulates this header to work with that. Still a draft: this change probably needs to be conditioned against nginx version with ifdefs, so older version can still be built as well. Hence, still a draft. Attempts to fix #1749
oschaaf
changed the title
dvershinin
added a commit
to GetPageSpeed/incubator-pagespeed-ngx
that referenced
this pull request
Jun 30, 2022
|
closing this in favor of #1751 |
oschaaf
pushed a commit
that referenced
this pull request
Jun 30, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As of nginx 1.23 the cache control headers are re-implemented as al linked list.
This reworks our code that manipulates this header to work with that.
Still a draft: this change probably needs to be conditioned against nginx version
with ifdefs, so older version can still be built as well. Hence, still a draft.
Attempts to fix #1749