Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

rpc message: remove dsn_message_t #168

Merged
merged 1 commit into from Aug 20, 2018
Merged

Conversation

shengofsun
Copy link
Contributor

No description provided.

Copy link
Contributor

@neverchanje neverchanje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@qinzuoyan qinzuoyan merged commit c4507ad into apache:master Aug 20, 2018
@sunwsh
Copy link

sunwsh commented Aug 23, 2018

dsn_message_t 这个为什么要删除的? 好奇问一下这个原来有什么问题吗?

@neverchanje
Copy link
Contributor

CC @shengofsun
dsn_message_t 是这个项目的历史遗留,dsn_message_t = message_ex* 被广泛使用在 rdsn 里面,但是 c++ 使用裸指针非常危险,所以我们计划把 dsn_message_t 移除,后面全部使用 message_ptr = ref_ptr<message_ex>

@shengofsun
Copy link
Contributor Author

@sunwsh dsn_message_t是之前microsoft/rDSN项目添加的,目的是提供一层C接口供别的编程语言使用。最近大半年,我们一直都在清除这种让代码变得晦涩和难维护的中间层。最终目的,是希望项目能成为清晰易维护的C++存储系统。
这是其他的项目整理计划,有兴趣可以一起参与:XiaoMi/rdsn#141

neverchanje pushed a commit to neverchanje/pegasus that referenced this pull request Jul 13, 2019
Former-commit-id: 83ad1e9faf4ed2d1f6ed80d95b00670f524a8493 [formerly c4507ad]
Former-commit-id: a8c89e49cb702e87da0d06ded746c9b989e1f910
cauchy1988 added a commit to cauchy1988/incubator-pegasus that referenced this pull request May 7, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants