server: support app env rocksdb.checkpoint.reserve_min_count and rock… #252
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…sdb.checkpoint.reserve_time_seconds
hycdong
previously approved these changes
Jan 10, 2019
acelyc111
reviewed
Jan 10, 2019
| } | ||
| } | ||
|
|
||
| if (count != _checkpoint_reserve_min_count) { |
There was a problem hiding this comment.
看花眼了。。
不过count和time，如果其中一个解析成功，另一个失败（这时实际是in_config中的值，或者一个负值），但同时都不等于当前值，是不是都要去设置？
hycdong
previously approved these changes
Jan 10, 2019
acelyc111
approved these changes
Jan 10, 2019
hycdong
approved these changes
Jan 10, 2019
qinzuoyan
added a commit
that referenced
this pull request
Feb 27, 2019
…sdb.checkpoint.reserve_time_seconds (#252)
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
…sdb.checkpoint.reserve_time_seconds (apache#252) Former-commit-id: 82d9b1664f3ff1c1fe47b68f2bc7459f9ee17495 [formerly f8d8060] Former-commit-id: 7ac4a9bff3276cf4240fe97155a030fefa928236
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…sdb.checkpoint.reserve_time_seconds
for the reason, please refer to Rocksdb-Checkpoint管理