shell: copy_data command supports filter #271
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
neverchanje
reviewed
Feb 15, 2019
src/shell/command_helper.h
Outdated
| @@ -101,6 +102,9 @@ struct scan_data_context | |||
| int split_id; | |||
| int max_batch_count; | |||
| int timeout_ms; | |||
| bool no_overwrite; // for copy_data | |||
There was a problem hiding this comment.
应该加一行注释 "uses check_and_set instead of using set for insertion"，单看这个选项不容易看明白
neverchanje
previously approved these changes
Feb 15, 2019
neverchanje
approved these changes
Feb 15, 2019
mentoswang
approved these changes
Feb 15, 2019
qinzuoyan
added a commit
that referenced
this pull request
Feb 27, 2019
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: cc19a265e963e04b85b803b2743c515f70b7dae0 [formerly 7314ec1] Former-commit-id: 4572a781737f2405934ac0522a66944937a1a50d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
improve shell's copy_data command:
--partitionoption--no_overwriteoption