shell: improve subcommand app_stat and nodes #277
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qinzuoyan
requested review from
shengofsun,
neverchanje,
acelyc111,
hycdong and
mentoswang
acelyc111
reviewed
Feb 19, 2019
| for (int i = 0; i < partitions.size(); i++) { | ||
| const dsn::partition_configuration &p = partitions[i]; | ||
| if (!p.primary.is_invalid()) { | ||
| auto find = tmp_map.find(p.primary); |
There was a problem hiding this comment.
find改下名字? 一是跟函数find重名,二是不知道啥内容
neverchanje
approved these changes
Feb 19, 2019
mentoswang
approved these changes
Feb 19, 2019
qinzuoyan
added a commit
that referenced
this pull request
Feb 27, 2019
neverchanje
pushed a commit
to neverchanje/pegasus
that referenced
this pull request
Jul 13, 2019
Former-commit-id: c459eebd8ef3f8aca5a2fe4abee23fd4edf2fd3b [formerly ea490d3] Former-commit-id: 125bed9901bb1c05c4e405cae0b19b79a46160be
acelyc111
pushed a commit
that referenced
this pull request
Jun 23, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
for app_stat:
rdb_mem_mbtomem_tbl_mbandmem_idx_mb.for nodes:
-r|--resolve_ipoption.-u|--resource_usageoption to add columns:memused_res_mb,block_cache_mb,mem_tbl_mb mem_idx_mb,disk_avl_total_ratio,disk_avl_min_ratio.