Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

jms build issue #514

Merged
merged 1 commit into from
Feb 25, 2024
Merged

jms build issue #514

merged 1 commit into from
Feb 25, 2024

Conversation

pjfanning
Copy link
Contributor

@pjfanning pjfanning commented Feb 25, 2024 •
edited
Loading

  • build of main branch is broken (CI only) - the build works on my laptop
  • I'm not sure if a corrupt version of the jms jar is being used
  • none of the recent merges seem to be the cause - I've tried reverting them

@pjfanning pjfanning changed the title [DRAFT] jms build jms build issue Feb 25, 2024
@mdedetrich
Copy link
Contributor

Can we drop the update of the build.sbt version in the Update build.properties commit and let scala-steward do it (or in a separate PR).

Otherwise it seems like its necessary to fix the build which I don't think is the case?

@pjfanning pjfanning mentioned this pull request Feb 25, 2024
Merged
@pjfanning
Update Dependencies.scala
8aa5808 
Update Dependencies.scala
mdedetrich
mdedetrich approved these changes Feb 25, 2024
View reviewed changes
Copy link
Contributor

@mdedetrich mdedetrich left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, the jms test passed

@pjfanning pjfanning merged commit 8491345 into apache:main Feb 25, 2024
50 checks passed
@pjfanning pjfanning deleted the jms-build branch February 25, 2024 21:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mdedetrich mdedetrich mdedetrich approved these changes

@He-Pin He-Pin Awaiting requested review from He-Pin

@nvollmar nvollmar Awaiting requested review from nvollmar

@samueleresca samueleresca Awaiting requested review from samueleresca

@Roiocam Roiocam Awaiting requested review from Roiocam

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pjfanning @mdedetrich