Remove usages of Stream #74
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hmm |
mdedetrich
force-pushed
the
remove-usages-of-stream
branch
from
eb48808
to
c2ce315
Compare
mdedetrich
commented
Mar 21, 2023
| private def readStream(stream: InputStream): ByteString = { | ||
| val reader = new BufferedInputStream(stream) | ||
| try ByteString(Stream.continually(reader.read).takeWhile(_ != -1).map(_.toByte).toArray) | ||
| try ByteString(Iterator.continually(reader.read).takeWhile(_ != -1).map(_.toByte).toArray) |
There was a problem hiding this comment.
So I realized what the underlying problem was, it turns out that specifically for Scala 2.12, ByteString is missing the apply method for an Iterator where as this exists in Scala 2.13. This is likely an oversight and a PR at Pekk was created at apache/pekko#257 to resolve this.
When that PR lands its possible to remove the .toArray, in any case both variants are equivalent to eachother because internally in the ByteString.apply it converts it to an Array anyways.
mdedetrich
requested review from
gmethvin,
He-Pin,
jrudolph,
nvollmar and
seglo
|
@pjfanning PR is now ready |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Completely removes usages of
Stream, making #71 redudnant.Resolves: #71