Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Reject table creation request with space characters in table name. #5730

Open
chenboat opened this issue Jul 22, 2020 · 1 comment
Open

Reject table creation request with space characters in table name. #5730

chenboat opened this issue Jul 22, 2020 · 1 comment

Comments

@chenboat
Copy link
Contributor

Today one can create a Pinot table with space characters in its name. We should reject such request because many downstream process like realtime ingestion do table name check about space characters.

E.g.,

java.net.URISyntaxException: Illegal character in query at index 87: http://streampinot-prod42-dca8:5983/segmentStoppedConsuming?name=emobility_rental_event __2__0__20200309T2338Z&offset=1425241&instance=Server_streampinot-prod138-dca8_7090&reason=org.apache.pinot.core.realtime.stream.TransientConsumerException
	at java.net.URI$Parser.fail(URI.java:2848)
	at java.net.URI$Parser.checkChars(URI.java:3021)
	at java.net.URI$Parser.parseHierarchical(URI.java:3111)
	at java.net.URI$Parser.parse(URI.java:3053)
	at java.net.URI.<init>(URI.java:588)
	at o.a.p.s.r.ServerSegmentCompletionProtocolHandler.sendRequest(ServerSegmentCompletionProtocolHandler.java:179)
	at o.a.p.s.r.ServerSegmentCompletionProtocolHandler.segmentStoppedConsuming(ServerSegmentCompletionProtocolHandler.java:157)
	at o.a.p.c.d.m.r.LLRealtimeSegmentDataManager.postStopConsumedMsg(LLRealtimeSegmentDataManager.java:857)
	at o.a.p.c.d.m.r.LLRealtimeSegmentDataManager$PartitionConsumer.run(LLRealtimeSegmentDataManager.java:5...
@xiangfu0
Copy link
Contributor

xiangfu0 commented Jul 22, 2020

Make sense.
I had one PR to prevent users from creating tables with dot: #5714

I think we can extend it to evaluate a valid table name here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants