Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Disallow table creation with dot in the table name #5714

Merged
merged 1 commit into from
Jul 21, 2020
Merged

Disallow table creation with dot in the table name #5714

merged 1 commit into from
Jul 21, 2020

Conversation

xiangfu0
Copy link
Contributor

@xiangfu0 xiangfu0 commented Jul 18, 2020 •
edited

Description

Disallow dot in table name during table creation.

Release Notes

Disallow dot in table name during table creation.

Backward compatibility:

  • No impact on existing tables, but no longer allow new table creation with dot in table name.

Jackie-Jiang
Jackie-Jiang reviewed Jul 18, 2020
View reviewed changes
Copy link
Contributor

@Jackie-Jiang Jackie-Jiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This will prevent people from updating the existing tables with dot in the table name

@xiangfu0 xiangfu0 force-pushed the disallow_table_creation_with_dot branch from 6d0ae69 to 7ebd02c Compare July 18, 2020 21:54
@xiangfu0
Copy link
Contributor Author

This will prevent people from updating the existing tables with dot in the table name

True, moved the table name check inside table creation.

@xiangfu0 xiangfu0 force-pushed the disallow_table_creation_with_dot branch from 7ebd02c to 6abf49c Compare July 20, 2020 23:02
@xiangfu0 xiangfu0 force-pushed the disallow_table_creation_with_dot branch from 6abf49c to 3ce4b6b Compare July 20, 2020 23:20
@xiangfu0 xiangfu0 merged commit 8e412b5 into master Jul 21, 2020
@xiangfu0 xiangfu0 deleted the disallow_table_creation_with_dot branch July 21, 2020 03:02
@xiangfu0 xiangfu0 mentioned this pull request Jul 22, 2020
Open
@xiangfu0 xiangfu0 linked an issue Jul 23, 2020 that may be closed by this pull request
Disallow dot in table name and column name. #5716
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Jackie-Jiang Jackie-Jiang Jackie-Jiang approved these changes

@kishoreg kishoreg Awaiting requested review from kishoreg

@siddharthteotia siddharthteotia Awaiting requested review from siddharthteotia

@mcvsubbu mcvsubbu Awaiting requested review from mcvsubbu

@mayankshriv mayankshriv Awaiting requested review from mayankshriv

@npawar npawar Awaiting requested review from npawar

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Disallow dot in table name and column name.
2 participants
@xiangfu0 @Jackie-Jiang