Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TE] frontend = aaronucsd/removed error default state #2685

Closed
wants to merge 1 commit into from

Conversation

aaronucsd
Copy link

No description provided.

@aaronucsd aaronucsd requested a review from apucher March 30, 2018 19:12
@apucher
Copy link
Contributor

apucher commented Mar 30, 2018

I wonder if this is actually the root-cause :-) It seems like the RCA controller should catch error by itself and fix it.

@aaronucsd
Copy link
Author

@apucher Yeah, my error catch all for any route that does not handle it itself. So the fix really is why it broke and gracefull add code to handle the error. But you said the catch-all return home` link was preventing so i can remove for now. But this is meant to catch any error that bubbled all the why up.

@aaronucsd
Copy link
Author

I don't have much context yet until i research into it more..Maybe leave the error substate for now?

@apucher
Copy link
Contributor

apucher commented Mar 30, 2018

yes. i'd leave this in for now and instead add some "message-and-reset-to-blank" error-handling in the rootcause route

@npawar npawar closed this May 22, 2020
@npawar
Copy link
Contributor

npawar commented May 22, 2020

Closed this PR due to 6 months inactivity. Reopen if needed.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants