Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Updating license and notice binary files for aea8fca7e #4524

Merged
merged 1 commit into from
Aug 13, 2019

Conversation

mcvsubbu
Copy link
Contributor

Updated the license and notice binaries as per instructions in
https://cwiki.apache.org/confluence/display/PINOT/Creating+an+Apache+Release
These files are as of commit aea8fca from which we expect to cut
pinot-0.2.0 release

Updated the license and notice binaries as per instructions in
https://cwiki.apache.org/confluence/display/PINOT/Creating+an+Apache+Release
These files are as of commit aea8fca from which we expect to cut
pinot-0.2.0 release
@mcvsubbu mcvsubbu requested a review from snleee August 13, 2019 00:42
Copy link
Contributor

@snleee snleee left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Have you checked that the # of libraries in LICENSE-binary matches with the html file that you generated? I remember that the name was somewhere around 171.

If that's the case, LGTM.

@mcvsubbu
Copy link
Contributor Author

Veriified. Excluding the pinot packages, there are a total of 154 packages.

@mcvsubbu mcvsubbu merged commit 3299444 into apache:master Aug 13, 2019
@mcvsubbu mcvsubbu deleted the update-license-files-for-0.2.0 branch August 13, 2019 15:29
chenboat pushed a commit to chenboat/incubator-pinot that referenced this pull request Nov 15, 2019
Updated the license and notice binaries as per instructions in
https://cwiki.apache.org/confluence/display/PINOT/Creating+an+Apache+Release
These files are as of commit aea8fca from which we expect to cut
pinot-0.2.0 release
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants