Adding push job type of segment metadata only mode #5967
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xiangfu0
force-pushed
the
segment_metadata_push
branch
2 times, most recently
from
e3095b2
to
cb159a3
Compare
|
Curious, why is this mode needed? Could this lead to inconsistency between metadata and segments? |
This mode should be used in caution. |
I see. I can see this can be a useful tool for issue mitigation. It'll be good to add some description of the scenarios that it targets in the PR description. |
xiangfu0
force-pushed
the
segment_metadata_push
branch
2 times, most recently
from
bb4e5da
to
7d72d38
Compare
xiangfu0
force-pushed
the
segment_metadata_push
branch
from
7d72d38
to
a0aa8e6
Compare
...ava/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
Outdated
Show resolved
Hide resolved
...ava/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Outdated
Show resolved
Hide resolved
Jackie-Jiang
approved these changes
Sep 29, 2020
...ava/org/apache/pinot/controller/api/resources/PinotSegmentUploadDownloadRestletResource.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Outdated
Show resolved
Hide resolved
...on-common/src/main/java/org/apache/pinot/plugin/ingestion/batch/common/SegmentPushUtils.java
Outdated
Show resolved
Hide resolved
xiangfu0
force-pushed
the
segment_metadata_push
branch
3 times, most recently
from
2d32aaf
to
dc89494
Compare
xiangfu0
force-pushed
the
segment_metadata_push
branch
from
dc89494
to
41ce862
Compare
xiangfu0
force-pushed
the
segment_metadata_push
branch
from
41ce862
to
d7ca99f
Compare
xiangfu0
added
the
release-notes
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
METADATA/segments/metadataendpoint to upload segment with METADATA only mode.