-
Notifications
You must be signed in to change notification settings - Fork 1.3k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
add query option of disabling upsert during query #6141
Conversation
Codecov Report
@@ Coverage Diff @@
## master #6141 +/- ##
==========================================
+ Coverage 66.44% 72.78% +6.34%
==========================================
Files 1075 1231 +156
Lines 54773 58057 +3284
Branches 8168 8567 +399
==========================================
+ Hits 36396 42259 +5863
+ Misses 15700 13020 -2680
- Partials 2677 2778 +101
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
disableUpsert
is a bit confusing. Initially it led me to believe that it is actually going to disable upsert operation, which led me to question why the read path should have the option to disable upsert in the write path.
Upon reading the changes, I feel a better name might be something along the lines of skipUpsert
, ignoreUpsert
or skipUpsertedDocIds
, for better readability.
Makes sense. I prefer |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with minor comments
@@ -64,6 +67,10 @@ public boolean isPreserveType() { | |||
return _preserveType; | |||
} | |||
|
|||
public boolean isUpsertSkipped() { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(nit) isSkipUpsert()
to be consistent with the variable name?
Description
Part of a series of PRs for #4261
Check this doc out for the new design
Add a query option for skipping upsert (mostly for debugging purpose)
displays: