Adding custom metadata props into both segment metadata properties file and zk metadata record #6299
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov Report
@@ Coverage Diff @@
## master #6299 +/- ##
===========================================
- Coverage 66.44% 45.79% -20.66%
===========================================
Files 1075 1252 +177
Lines 54773 61233 +6460
Branches 8168 8866 +698
===========================================
- Hits 36396 28043 -8353
- Misses 15700 30897 +15197
+ Partials 2677 2293 -384
Flags with carried forward coverage won't be shown. Click here to find out more.
Continue to review full report at Codecov.
|
xiangfu0
force-pushed
the
all_custom_metadata_props_in_segment_creation
branch
3 times, most recently
from
a05ccdd
to
2b0df65
Compare
…le and zk metadata record
xiangfu0
force-pushed
the
all_custom_metadata_props_in_segment_creation
branch
from
2b0df65
to
1e8393f
Compare
Jackie-Jiang
approved these changes
Dec 1, 2020
| for (String key : _customMap.keySet()) { | ||
| customConfigs.put(key, _customMap.get(key)); | ||
| } | ||
| segmentMetadata.set("custom", customConfigs); |
There was a problem hiding this comment.
here I kind of following the convention that all the previous field names are in strings.
There was a problem hiding this comment.
And this is only used by the rest api
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Allow adding custom configs during the segment creation phase, and made those available in both segment metadata property file and zookeeper znRecord.
Note that those configs will have
custom.prefix in metadata.properties file.Sample output:
metadata.property file:
zk metadata:
