Conversation
Integrate new predictionio template of Sentiment analysis - bag of words model.
Update templates.yaml
Hi @bansarishah , thanks for the pull request. Would you mind changing the subject to include the JIRA ticket number so that they are linked? It would be sufficient to just add |
Hi.. Thank you Regards, On Thu, Sep 8, 2016 at 5:24 AM, Donald Szeto notifications@github.com
|
Thanks for your contribution @bansarishah ! Most of it looks great to me. A few suggested improvement:
I will hold this until the Apache release is out. PredictionIO 0.10.0 has reached RC status. Once the final release is published, we will accept this PR after the engine template is modified to use the final released artifact. |
I have updated template with 'PEventStore' API. Now it works on appName instead appId and have mentioned it's use in README.md |
It is updated with template "topic labelling with wikipedia"
Update templates.yaml
I have done one more commit with addition of new template "Topic labelling with Wikipedia" in templates.yaml. It relates to Jira Issue [PIO-34] . |
Hi @bansarishah , now that 0.10.0-incubating has released, would you mind updating your template to use those new artifacts? Once that's done I will merge this in. You might also want to redo this against the |
Modified templates build with new apache predictionio release artifact.
Update templates.yaml
Thank you @bansarishah ! Merging this to |
Integrate new predictionIO template of sentiment analysis - Bag of words model.