Skip to content
This repository has been archived by the owner on May 12, 2021. It is now read-only.

[PIO-34]Update templates.yaml #292

Closed
wants to merge 6 commits into from
Closed

[PIO-34]Update templates.yaml #292

wants to merge 6 commits into from

Conversation

bansarishah
Copy link
Contributor

Integrate new predictionIO template of sentiment analysis - Bag of words model.

bansarishah and others added 2 commits September 6, 2016 16:11
Integrate new predictionio template of  Sentiment analysis - bag of words model.
@dszeto
Copy link
Contributor

dszeto commented Sep 7, 2016

Hi @bansarishah , thanks for the pull request. Would you mind changing the subject to include the JIRA ticket number so that they are linked? It would be sufficient to just add [PIO-34] in front of the current subject.

@bansarishah bansarishah changed the title Update templates.yaml [PIO-34]Update templates.yaml Sep 8, 2016
@bansarishah
Copy link
Contributor Author

Hi..
I have changed subject from "Update templates.yaml " to "[PIO-34] Update
templates.yaml"
Please consider it

Thank you

Regards,
Bansari Shah

On Thu, Sep 8, 2016 at 5:24 AM, Donald Szeto notifications@github.com
wrote:

Hi @bansarishah https://github.com/bansarishah , thanks for the pull
request. Would you mind changing the subject to include the JIRA ticket
number so that they are linked? It would be sufficient to just add
[PIO-34] in front of the current subject.


You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
#292 (comment),
or mute the thread
https://github.com/notifications/unsubscribe-auth/ATJryECMVXvkAan7STHUBFM-n-ZzbLZUks5qn06ygaJpZM4J1tIG
.

@dszeto
Copy link
Contributor

dszeto commented Sep 9, 2016

Thanks for your contribution @bansarishah ! Most of it looks great to me. A few suggested improvement:

  • highlight the need to change appId in engine.json
  • or even better, use the PEventStore API so that it relies on the app name rather than ID

I will hold this until the Apache release is out. PredictionIO 0.10.0 has reached RC status. Once the final release is published, we will accept this PR after the engine template is modified to use the final released artifact.

@bansarishah
Copy link
Contributor Author

I have updated template with 'PEventStore' API. Now it works on appName instead appId and have mentioned it's use in README.md
Please consider it.
Thank you

bansarishah and others added 2 commits October 5, 2016 19:21
It is updated with template "topic labelling with wikipedia"
@bansarishah
Copy link
Contributor Author

bansarishah commented Oct 5, 2016

I have done one more commit with addition of new template "Topic labelling with Wikipedia" in templates.yaml. It relates to Jira Issue [PIO-34] .
Please consider it.
Thank you.

@dszeto
Copy link
Contributor

dszeto commented Oct 11, 2016

Hi @bansarishah , now that 0.10.0-incubating has released, would you mind updating your template to use those new artifacts? Once that's done I will merge this in.

You might also want to redo this against the livedoc branch if you want your entry to show up immediately on the live web site. Thanks!

bansarishah and others added 2 commits October 18, 2016 12:00
Modified templates build with new apache predictionio release artifact.
@bansarishah
Copy link
Contributor Author

bansarishah commented Oct 18, 2016

Hi @dszeto , I have updated template to use predictionio new release 0.10.0-incubating.
To merge with livedoc branch i have done pull request "[PIO-34]Update templates.yaml #315"
Please consider it.
Thank you

@dszeto
Copy link
Contributor

dszeto commented Nov 2, 2016

Thank you @bansarishah ! Merging this to livedoc.

@asfgit asfgit closed this in 03e9981 Dec 16, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
3 participants